Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplex the Vault Provider #2382

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

vinay-gopalan
Copy link
Contributor

Description

Relates OR Closes #0000

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

fairclothjm and others added 7 commits November 15, 2023 10:38
…mplementation (#2067)

* implement the framework provider

* setup provider server factory

* setup framework provider schema

* handle defaults in configure

* [Phase 2] Complete the provider configuration setup (#2090)

* setup framework provider schema

* handle defaults in configure

* WIP: handle auth login methods

* [Phase 2] Include Auth Login blocks in multiplexed Provider configuration (#2097)

make updates to all auth logins and fix build

run go mod tidy

register all auth logins to test build

add all auth login blocks and match schema implementations

set default for azure scope

address todos

- remove commented code; neither are read from env vars
- add validators

* remove set_namespace_from_token field

* add custom path validator

* configure namespace for vault client

* review comments

* add muxed provider acc tests

* use consts, set required fields and update tests

* add tests for multi envs and fix bug

* fix bug with overriding config val

* add custom URI validator for OIDC auth

* fix a few default mount types

* add comments and migration state example acc test

* remove dupe default entries; add validators

* remove client_auth docs

* add kerbos token and file path validators

* don't use double pointer and remove redundant return

---------

Co-authored-by: vinay-gopalan <[email protected]>

---------

Co-authored-by: vinay-gopalan <[email protected]>
…#2113)

* move new fw resources to internal/vault/ dir

* Add acc tests for password policy resource

* remove provider factory from test step

* remove password_policy.go
* refactor base schema for legacy vs new resources

* add helpers to base for configure and import

* fix import state by id for pass policy

* add ToAPIModel helper

* fix import with ImportState method

* add namespace import test helpers

* fix bug that required namespace; add separate non-namespace test

* refactor ToAPIModel helper

* add BaseModelLegacy and more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants